Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8234704: Fix attribution in libxslt.md #52

Closed
wants to merge 2 commits into from
Closed

8234704: Fix attribution in libxslt.md #52

wants to merge 2 commits into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 23, 2019 •
edited by openjdk bot

We discovered three minor differences between the libxslt.md file and the libxslt-1.1.34 source bundle:

  1. The copyright years didn't match the source

  2. The following line was missing:

Licence for libxslt except libexslt
  1. The terms currently lists BLFS rather than DANIEL VEILLARD in one place.

Note to reviewers:

I pushed this in two commits as an aid to reviewing it (as with any other PR, it will be squashed during integration). The first commit just fixes the above three issues without any reformatting of the lines. The second commit has no changes in the content itself, but re-wraps the lines to match the source.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8234704: Fix attribution in libxslt.md

Approvers

  • Phil Race (prr - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2019

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr Ready for review label Nov 23, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2019

Webrevs

@kevinrushforth
Copy link
Member Author

Reviewers: @prrace or @guruhb (only one reviewer should be needed)

@kevinrushforth kevinrushforth self-assigned this Nov 23, 2019
prrace
prrace suggested changes Nov 23, 2019
View reviewed changes
Copy link
Collaborator

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"THE DANIEL VEILLARD"

The one and only ? Was THE supposed to be here ?

@kevinrushforth
Copy link
Member Author

"THE DANIEL VEILLARD"

Strange as it may seem, yes. This is taken exactly from the COPYING file in the libxslt-1.1.34.tar.gz bundle.

@openjdk openjdk bot removed the rfr Ready for review label Nov 23, 2019
@openjdk
Copy link

openjdk bot commented Nov 23, 2019

@kevinrushforth This change can now be integrated. The commit message will be:

8234704: Fix attribution in libxslt.md

Reviewed-by: prr
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.
  • To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 23, 2019
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Nov 23, 2019
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels Nov 23, 2019
@openjdk
Copy link

openjdk bot commented Nov 23, 2019

@kevinrushforth
Pushed as commit 126896d.

@mlbridge
Copy link

mlbridge bot commented Nov 23, 2019

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: 126896d
Author: Kevin Rushforth
Date: 2019-11-23 17:42:53 +0000
URL: https://git.openjdk.java.net/jfx/commit/126896db

8234704: Fix attribution in libxslt.md

Reviewed-by: prr

! modules/javafx.web/src/main/legal/libxslt.md

@kevinrushforth kevinrushforth deleted the 8234704-libxslt.md branch November 23, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prrace prrace prrace approved these changes

Assignees

@kevinrushforth kevinrushforth

Labels
integrated Pull request has been integrated
Milestone
No milestone
2 participants
@kevinrushforth @prrace